16.0.0 - #596
Merged
Merged
Conversation
adonesky1
force-pushed
the
release/16.0.0
branch
from
September 16, 2021 18:36
9307f2f to
46babe8
Compare
Closed
Gudahtt
reviewed
Sep 16, 2021
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
reviewed
Sep 16, 2021
| - **BREAKING**: Remove `syncTokens` method from the TokenListController ([#590](https://github.com/MetaMask/controllers/pull/590)) | ||
| - This is breaking for any consumers of this method. | ||
| - Enable default caching for token-service ([#594](https://github.com/MetaMask/controllers/pull/594)) | ||
| - Set tokenList to empty object in test networks ([#588](https://github.com/MetaMask/controllers/pull/588)) |
Member
There was a problem hiding this comment.
This seems to be describing something internal - it doesn't make clear what the actual change was for consumers. It's not clear to me either from reading the PR.
My best guess is that this is a bug fix, and that the change was to clear the dynamic token list when switching to a network not supported by our token list API. Does that sound correct? cc @NiranjanaBinoy @danjm
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
adonesky1
force-pushed
the
release/16.0.0
branch
from
September 16, 2021 19:29
fde5342 to
01f8c96
Compare
Member
|
amitabh94
pushed a commit
to amitabh94/core
that referenced
this pull request
Jun 16, 2026
Core doesn't use sinon. This package only used it for
`useFakeTimers()` and a small `advanceTime` helper, both of
which have direct Jest equivalents:
- sinon.useFakeTimers() / clock.restore() ->
jest.useFakeTimers() / jest.useRealTimers()
- clock.tickAsync(stepSize) ->
jest.advanceTimersByTimeAsync(stepSize)
- `advanceTime({ clock, duration, stepSize })` ->
`advanceTime({ duration, stepSize })` (clock arg dropped)
Also bumps ts-jest ^29.1.4 -> ^29.2.5 to match core.
Test suite remains at 196/196 and now runs in ~2.5s (down from ~6s).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This a release candidate for v.16.0.0
[16.0.0]
Changed
Fixed