Skip to content

25.0.0 - #673

Merged
adonesky1 merged 3 commits into
mainfrom
release/25.0.0
Jan 10, 2022
Merged

25.0.0#673
adonesky1 merged 3 commits into
mainfrom
release/25.0.0

Conversation

@github-actions

@github-actions github-actions Bot commented Jan 10, 2022

Copy link
Copy Markdown
Contributor

This is the release candidate for version 25.0.0.

[25.0.0]

Added

  • Add optional third argument to method checkAndUpdateSingleCollectibleOwnershipStatus on CollectiblesController, which contains the userAddress and chainId to check asset ownership against. If not included, the method will still check against the currently configured selectedAddress and chainId configured in the CollectiblesController (#672)
  • Add getTokenStandardAndDetails method on AssetsContractController which determines whether the input contract confirms to particular known token standard (ERC20, ERC721 or ERC1155) and returns the detected standard along with some key values/details about that the contract and/or specified token within that contract (#667)

Changed

    • BREAKING - Standardize ERC721/1155/20 method names (#667)
    • Renames many methods on the AssetsContractController to include the contract type they are used by in the name in a standardized structure (i.e. getAssetName -> getERC721AssetName and balanceOfERC1155Collectible -> getERC1155BalanceOf).
    • Consumers will need to look at the AssetsContractController for any methods they consume and adapt names accordingly.
github-actions and others added 2 commits January 10, 2022 16:23
@adonesky1
adonesky1 marked this pull request as ready for review January 10, 2022 16:46
@adonesky1
adonesky1 requested a review from a team as a code owner January 10, 2022 16:46
gantunesr
gantunesr previously approved these changes Jan 10, 2022

@gantunesr gantunesr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adonesky1

Copy link
Copy Markdown
Contributor

Thanks Guto! Going to wait for review from @Gudahtt before merge.

@Gudahtt Gudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from that one typo!

Comment thread CHANGELOG.md Outdated
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@adonesky1

Copy link
Copy Markdown
Contributor

Thanks for pointing out the type @Gudahtt! Ready for another look!

@adonesky1
adonesky1 merged commit 2db7013 into main Jan 10, 2022
@adonesky1
adonesky1 deleted the release/25.0.0 branch January 10, 2022 23:43
@Gudahtt

Gudahtt commented Jan 11, 2022

Copy link
Copy Markdown
Member

A new version of the package @metamask/controllers (25.0.0) was published at 2022-01-11T14:48:52.197Z from
[redacted]. The shasum of this package was 764ba46a169f197253e35ca5273720c91eae7662.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants