feat: support cache location overrides (#177)#178
Conversation
Confidence Score: 3/5Safe to merge after fixing the test isolation gap; the production code change is correct and self-contained. The production code in cache.py is correct. The test suite has a gap: test_resolve_cache_folder does not unset SEMBLE_CACHE_LOCATION before exercising the platform helpers, so running make test in an environment where that variable is already configured will cause a spurious assertion failure. Combined with the broken Markdown rendering in the README, there are two issues that should be fixed before merging. tests/test_cache.py needs the existing parametrized test updated to neutralize SEMBLE_CACHE_LOCATION; README.md needs the mismatched quote fixed.
|
Adds support for a neew environment variable 'SEMBLE_CACHE_LOCATION'. The value of this variable will be the full path location of the cache folder that semble stores its caches and savings information. This variable takes precedence over and OS defaults and the Arch XDG_CACHE_HOME convention.
1d63a6b to
761ee16
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
|
Looks good from our side, thanks for your contribution! |
Adds support for a neew environment variable 'SEMBLE_CACHE_LOCATION'. The value of this variable will be the full path location of the cache folder that semble stores its caches and savings information.
This variable takes precedence over and OS defaults and the Arch XDG_CACHE_HOME convention.
Linked issue
Closes #177
Summary
Adds an environment variable to allow specifying the semble cache location if OS defaults do not suffice.
Checklist
make testpassesmake lintandmake typecheckpass (ormake pre-commit)