Added copyright header, LICENSE, and README.md#8
Merged
Dinnerbone merged 4 commits intomasterfrom Sep 26, 2018
Merged
Conversation
Dinnerbone
force-pushed
the
feature/copyright
branch
from
5fbf579 to
63a76c5
Compare
Dinnerbone
force-pushed
the
feature/copyright
branch
from
63a76c5 to
e54a50f
Compare
boq
approved these changes
Sep 26, 2018
|
|
||
| Command registration also encourages use of a builder pattern to keep code cruft to a minimum. | ||
|
|
||
| A "command" is a fairly loose term, but typically it means an exit point of the command tree. |
Member
There was a problem hiding this comment.
I'd argue that most people identify command by first literal after root, so that would make "command" a sub-tree and not just path leading to leaf node. /bikeshedding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for OSS :)