Skip to content

feat: add AoT compilation with webpack - #215

Merged
vakrilov merged 6 commits into
masterfrom
webpack-aot
Feb 8, 2017
Merged

feat: add AoT compilation with webpack#215
vakrilov merged 6 commits into
masterfrom
webpack-aot

Conversation

@sis0k0

@sis0k0 sis0k0 commented Feb 3, 2017

Copy link
Copy Markdown
Contributor

Implements #213

@tjvantoll tjvantoll left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One minor note: on iOS when I run the app with webpack bundling the status bar code doesn’t work for some reason.

I don’t think that should hold this up as it’s rather trivial (and works fine on Android), but I thought I’d mention it in case if you have any ideas what might be going on.

Comment thread app/app.module.ts
],
bootstrap: [AppComponent]
bootstrap: [AppComponent],
schemas: [NO_ERRORS_SCHEMA]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why is this necessary?

@tjvantoll

Copy link
Copy Markdown
Contributor

Here’s what I see on iOS.

screen shot 2017-02-06 at 1 08 07 pm

@vakrilov

vakrilov commented Feb 8, 2017

Copy link
Copy Markdown
Contributor

The white status-bar turned out to be caused by webpack not handling the ~ symbol in @import url("~/platform.css");.
@hdeshev will investigate if we can support that, but for now the workaround is just to use "./platform.css" instead.

@vakrilov
vakrilov merged commit e8b457f into master Feb 8, 2017
@vakrilov
vakrilov deleted the webpack-aot branch February 8, 2017 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants