feat: eager fallback to backup model on rate-limit errors#1730
Merged
Conversation
When a fallback model is configured, switch to it immediately upon detecting rate-limit conditions (429, quota exhaustion, empty/malformed responses) instead of exhausting all retries with exponential backoff. Two eager-fallback checks: 1. Invalid/empty API responses — fallback attempted before retry loop 2. HTTP 429 / rate-limit keyword detection — fallback before backoff Both guarded by _fallback_activated for one-shot semantics. Cherry-picked from PR #1413 by usvimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvage of PR #1413 by @usvimal, cherry-picked onto current main.
When a fallback model is configured, the agent now switches to it immediately upon detecting rate-limit conditions instead of exhausting all retries with exponential backoff.
Two eager-fallback checks added to
run_agent.py:Both paths guarded by
_fallback_activatedto preserve one-shot semantics.Test results
5130 passed, 5 pre-existing failures (unrelated
test_anthropic_adapter.py), 200 skipped.Closes #1413.