fix(gateway): include resolved node path in systemd unit#1767
Merged
teknium1 merged 1 commit intoNousResearch:mainfrom Mar 17, 2026
Merged
fix(gateway): include resolved node path in systemd unit#1767teknium1 merged 1 commit intoNousResearch:mainfrom
teknium1 merged 1 commit intoNousResearch:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nodebinary when generating the gateway systemd unit PATHnode_modules/.binentries unchanged~/.nvm/.../binProblem
On Linux, if Node is installed via
nvm,hermes gateway installcan generate a systemd unit whose PATH omits the actual Node binary directory. When WhatsApp is enabled, the gateway service then fails the WhatsApp bridge requirement check and can enter a restart loop.Reproduction
This was reproduced on a fresh Ubuntu 24.04 install with upstream
main, Node installed only throughnvm, and:Then:
The generated unit PATH omitted
~/.nvm/.../bin,nodewas missing under the service environment, and the gateway crash-looped.Fix
When generating the systemd unit, resolve
nodefrom the current install environment and append its parent directory to the service PATH if present.Test plan
./venv/bin/python -m pytest tests/hermes_cli/test_gateway_service.py -qCloses #1766