fix(discord): remove bugged followup messages + remove /ask command#1836
Merged
fix(discord): remove bugged followup messages + remove /ask command#1836
Conversation
/ask was just 'send a message to the bot' via the slash command menu — completely redundant since Discord bots already listen to channel messages. Removed as part of salvaging PR #1827.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks PR #1827 by @CharlieKerfoot (followup fix) and removes the redundant
/askslash command.Followup fix (from #1827):
Discord slash commands (
/reasoning,/voice) were sending unnecessary "Done~" or "Processing complete~" followup messages after the actual agent response was already sent via the normal adapter flow. Sometimes these followups replaced the real response. Fix: change_run_simple_slashdefaultfollowup_msgfrom"Done~"toNoneso only commands that explicitly need a followup (/new,/reset,/update) send one./askremoval:/askwas just "send a message to the bot" via the slash command menu — completely redundant since Discord bots already listen to channel messages. Removed.Supersedes #1827.
Test plan
python -m pytest tests/gateway/ -n0 -q— 1194 passed (2 pre-existing whatsapp failures, unrelated)