fix: add linebreak in gateway stream after tool calls (#2177)#2186
Closed
mr-emmett-one wants to merge 1 commit intoNousResearch:mainfrom
Closed
fix: add linebreak in gateway stream after tool calls (#2177)#2186mr-emmett-one wants to merge 1 commit intoNousResearch:mainfrom
mr-emmett-one wants to merge 1 commit intoNousResearch:mainfrom
Conversation
14 tasks
Contributor
|
Closing — duplicate of another open PR addressing the same issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a formatting bug where text generated after a tool call is concatenated directly to the tool progress indicator. This injects
\n\ninto the stream delta immediately after a tool finishes, ensuring the LLM's response starts on a clean line.Related Issue
Fixes #2177
Type of Change
[x] 🐛 Bug fix (non-breaking change that fixes an issue)
Changes Made
gateway/run.py: Addedstream_consumer_holder[0].on_delta("\n\n")insideprogress_callback.Checklist