fix: add input validation to send_message_tool to prevent crashes#2240
Closed
sprmn24 wants to merge 1 commit intoNousResearch:mainfrom
Closed
fix: add input validation to send_message_tool to prevent crashes#2240sprmn24 wants to merge 1 commit intoNousResearch:mainfrom
sprmn24 wants to merge 1 commit intoNousResearch:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds input validation to
send_message_toolto prevent crashes when invalid or malformed arguments are passed.Currently, the function assumes
argsis always a dictionary. However, in real-world usage (e.g. LLM outputs, external gateways like Telegram/Discord), this assumption may not hold. IfargsisNoneor not a dictionary, calling.get()results in:This PR ensures safer handling of such cases by validating input before usage.
Related Issue
No related issue
Type of Change
Changes Made
argsintools/send_message_tool.py.get()calls on non-dictionary inputsHow to Test
send_message_toolwith valid dictionary input → should behave normallysend_message_tool(None)→ should return JSON error instead of crashingsend_message_tool("invalid")→ should return JSON error safely