fix(tests): replace FakePath subclass with Path.exists patch for Python 3.12 compatibility#2244
Closed
teyrebaz33 wants to merge 1 commit intoNousResearch:mainfrom
Closed
Conversation
…on 3.12 compatibility
teyrebaz33
force-pushed
the
fix/gateway-service-test-path-mock-python312
branch
from
5442960 to
bf99a3d
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2243
Problem
TestEnsureUserSystemdEnv::test_sets_xdg_runtime_dir_when_missingfails on Python 3.12. The test used aFakePathsubclass overriding__new__to redirect/run/user/42to a temp directory. In Python 3.12,PosixPath.__new__ignores the redirected path argument and re-initializes from the original string, soexists()returnsFalseandXDG_RUNTIME_DIRis never set.Fix
Replace the
FakePathsubclass withmonkeypatch.setattr(gateway_cli.Path, "exists", ...)— patches the method directly on the class used by the module under test.Changes
tests/hermes_cli/test_gateway_service.py: 4 insertions, 12 deletions — single test method, no production code changes