fix(mattermost): use MIME types for media attachments#2329
Merged
Conversation
Bare strings like "image", "audio", "document" were appended to
media_types, but downstream run.py checks mtype.startswith("image/")
and mtype.startswith("audio/"), which never matched. This caused all
Mattermost file attachments to be silently dropped from vision/STT
processing. Use the actual MIME type from file_info instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of PR #1751 by @Himess (198 commits behind, cherry-picked cleanly).
Mattermost file attachments were silently dropped from vision and STT processing. The adapter appended bare category strings (
"image","audio","document") tomedia_types, but downstream checks inrun.pyusemtype.startswith("image/")which never matched.Fix: use the actual MIME type (
mimevariable, already available fromfile_info.get("mime_type")) instead of bare category strings. Three lines changed.3 new tests verify full MIME types are propagated for image, audio, and document attachments. 40 mattermost tests pass.