fix(security): add re.DOTALL to prevent multiline bypass of dangerous command detection#233
Merged
teknium1 merged 1 commit intoNousResearch:mainfrom Mar 2, 2026
Conversation
… command detection
Contributor
|
Mind me asking what formatter does this project use? opencode is messing up the format making it much harder to track the actual changes. |
Contributor
|
Merged — thanks for the security fix! Added 2 extra find-pattern newline tests as a follow-up. |
Contributor
Contributor
Author
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
TestMultilineBypasstotests/tools/test_approval.pywith 4 tests:curl ... \\\n| shdetectedwget ... \\\n| bashdetecteddd \\\nif=...detectedchmod --recursive \\\n777detectedAll 4 fail without the fix, all 33 tests pass with it.
Closes #232