fix(gateway): restart on WhatsApp bridge child exit (salvage #2324)#2334
Merged
fix(gateway): restart on WhatsApp bridge child exit (salvage #2324)#2334
Conversation
19 tasks
outsourc-e
pushed a commit
to outsourc-e/hermes-agent
that referenced
this pull request
Mar 26, 2026
Co-authored-by: Frederico Ribeiro <fr@tecompanytea.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvage of PR #2324 by @ifrederico, cherry-picked onto current main.
When the WhatsApp gateway manages a Node.js bridge child process and that process exits after startup, the Python gateway previously kept running with every poll/send failing forever. This fix:
_check_managed_bridge_exit()to detect managed bridge child exit viapoll()whatsapp_bridge_exited)Restart=on-failurecan recover it_runningassignment with_mark_connected()/_mark_disconnected()base adapter methodsPairs with the recently merged #2319 (systemd restart rate limiting) to prevent restart storms.
Verification
_set_fatal_errorsets_running=Falseimmediately,has_fatal_errorguard prevents double-notificationCredit
Original work by @ifrederico in #2324. Contributor authorship preserved via cherry-pick.