fix(cli): handle Kitty keyboard protocol Shift+Enter for Ghostty/WezTerm#2345
Merged
fix(cli): handle Kitty keyboard protocol Shift+Enter for Ghostty/WezTerm#2345
Conversation
Kitty-protocol terminals (Ghostty, WezTerm) encode Shift+Enter as CSI 13;2u instead of plain Enter. Without this binding, raw escape characters appear in the input buffer. Adds s-enter and the Kitty escape sequence as newline-insert bindings. Based on work by ygd58 in PR #1798. Fixes #1795. Registry.py apostrophe sanitization change excluded (unrelated scope).
outsourc-e
pushed a commit
to outsourc-e/hermes-agent
that referenced
this pull request
Mar 26, 2026
Reverts the s-enter and Kitty CSI keybindings from PR NousResearch#2345/NousResearch#2346. The s-enter key notation causes 'Invalid key: s-enter' crash on some prompt_toolkit versions, breaking hermes startup entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of PR #1798 by @ygd58 — cli.py keybinding only, registry.py apostrophe sanitization excluded as unrelated.
Kitty-protocol terminals (Ghostty, WezTerm) encode Shift+Enter as
CSI 13;2uinstead of plain Enter. Without this binding, raw[13;2utext appears in the input buffer. Addss-enterand the Kitty escape sequence as newline-insert bindings.Harmless in regular terminals — these bindings only fire if the terminal sends the specific sequences. Fixes #1795.