fix(telegram): escape bare parentheses/braces in MarkdownV2 output#2386
Merged
fix(telegram): escape bare parentheses/braces in MarkdownV2 output#2386
Conversation
The MarkdownV2 format_message conversion left unescaped ( ) { }
in edge cases where placeholder processing didn't cover them (e.g.
partial link matches, URLs with parens). This caused Telegram to
reject the message with 'character ( is reserved and must be escaped'
and fall back to plain text — losing all formatting.
Added a safety-net pass (step 12) after placeholder restoration that
escapes any remaining bare ( ) { } outside code blocks and valid
MarkdownV2 link syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From bitfalt's gateway logs: 77 MarkdownV2 parse failures, all 'character ( is reserved and must be escaped'. Every long response with parentheses fell back to plain text, losing all formatting.
The MarkdownV2 conversion (
format_message) correctly escapes parens in step 10, but edge cases in placeholder processing left some unescaped — partial link matches, URLs with parens in them, etc.Fix: Added step 12 after placeholder restoration — a safety-net pass that catches any remaining bare
( ) { }outside code blocks and valid link syntax, and escapes them. Splits text into code/non-code segments first so code block contents are never touched.114 Telegram tests pass.