fix(redact): safely handle non-string inputs (salvage #2369)#2392
Merged
fix(redact): safely handle non-string inputs (salvage #2369)#2392
Conversation
redact_sensitive_text() now returns early for None and coerces other non-string values to str before applying regex-based redaction, preventing TypeErrors in logging/tool-output paths. Cherry-picked from PR #2369 by aydnOktay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvage of PR #2369 by @aydnOktay. Cherry-picked cleanly onto current main.
redact_sensitive_text()now handles non-string inputs defensively:Noneearly forNoneinput (explicit check instead of relying on truthiness)strbefore applying regex patternsTypeErrorcrashes when non-string values flow through logging/tool-output pathsTwo new tests: int coercion and dict coercion with redaction.
Tests: 31/31 redact tests passing.
Credit: @aydnOktay (original author, commit authorship preserved).