fix(signal): use id instead of attachmentId in getAttachment RPC#2400
Merged
fix(signal): use id instead of attachmentId in getAttachment RPC#2400
Conversation
Cherry-picked from PR #2365 by @xerpert. Three bugs preventing Signal image attachments from being processed: 1. signal-cli getAttachment RPC expects 'id', not 'attachmentId' 2. signal-cli daemon returns dict {"data": "base64..."} not raw base64 3. MessageType.IMAGE doesn't exist — correct enum is MessageType.PHOTO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from PR #2365 by @xerpert.
Three bugs preventing Signal image attachments from being processed:
attachmentId→idin getAttachment RPC (matches signal-cli's actual API){"data": "base64..."}from signal-cli daemonMessageType.IMAGE→MessageType.PHOTO(correct enum value — IMAGE doesn't exist)33 signal tests passing.