fix(model_metadata): use /v1/props endpoint for llama.cpp context detection#2403
Merged
fix(model_metadata): use /v1/props endpoint for llama.cpp context detection#2403
Conversation
…ection Recent versions of llama.cpp moved the server properties endpoint from /props to /v1/props (consistent with the /v1 API prefix convention). The server-type detection path and the n_ctx reading path both used the old /props URL, which returns 404 on current builds. This caused the allocated context window size to fall back to a hardcoded default, resulting in an incorrect (too small) value being displayed in the TUI context bar. Fix: try /v1/props first, fall back to /props for backward compatibility with older llama.cpp builds. Both paths are now handled gracefully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #2230 by @RufusLin.
Recent llama.cpp builds moved
/propsto/v1/props. Both detection paths (server type + context length) now try/v1/propsfirst, falling back to/propsfor older builds.All 94 model_metadata tests pass.