fix: /stop command crash + UnboundLocalError in streaming media delivery#2463
Merged
fix: /stop command crash + UnboundLocalError in streaming media delivery#2463
Conversation
Two fixes: 1. CLI /stop command crashed with 'cannot import name get_registry' — the code imported a non-existent function. Fixed to use the actual process_registry singleton and list_sessions() method. (Reported in #2458 by haiyuzhong1980) 2. Streaming media delivery used undefined 'adapter' variable — our PR #2382 called _deliver_media_from_response(adapter=adapter) but 'adapter' wasn't guaranteed to be defined in that scope. Fixed to resolve via self.adapters.get(source.platform). (Reported in #2424 by 42-evey)
This was referenced Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes from the open PR scan:
1. /stop crashes with ImportError (#2458)
CLI imported non-existent
get_registry()fromprocess_registry. Fixed to use the actualprocess_registrysingleton andlist_sessions()method.2. Streaming media delivery uses undefined variable (#2424)
Our PR #2382 called
_deliver_media_from_response(adapter=adapter)butadapterwasn't defined in that scope — it would crash withUnboundLocalErrorwhen streaming mode delivered MEDIA: tags. Fixed to resolve viaself.adapters.get(source.platform).2 files, +8/-7.