fix: expand tilde (~) in vision_analyze local file paths#2585
Merged
Conversation
Path('~/.hermes/image.png').is_file() returns False because Path
doesn't expand tilde. This caused the tool to fall through to URL
validation, which also failed, producing a confusing error:
'Invalid image source. Provide an HTTP/HTTPS URL or a valid local
file path.'
Fix: use os.path.expanduser() before constructing the Path object.
Added two tests for tilde expansion (success and nonexistent file).
outsourc-e
pushed a commit
to outsourc-e/hermes-agent
that referenced
this pull request
Mar 26, 2026
…h#2585) Path('~/.hermes/image.png').is_file() returns False because Path doesn't expand tilde. This caused the tool to fall through to URL validation, which also failed, producing a confusing error: 'Invalid image source. Provide an HTTP/HTTPS URL or a valid local file path.' Fix: use os.path.expanduser() before constructing the Path object. Added two tests for tilde expansion (success and nonexistent file).
aashizpoudel
pushed a commit
to aashizpoudel/hermes-agent
that referenced
this pull request
Mar 30, 2026
…h#2585) Path('~/.hermes/image.png').is_file() returns False because Path doesn't expand tilde. This caused the tool to fall through to URL validation, which also failed, producing a confusing error: 'Invalid image source. Provide an HTTP/HTTPS URL or a valid local file path.' Fix: use os.path.expanduser() before constructing the Path object. Added two tests for tilde expansion (success and nonexistent file).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vision_analyzefailed when given paths like~/image.pngbecausePath('~/...')doesn't expand tilde. The tool fell through to URL validation, producing a confusing error: Invalid image source.Fix
One-line change: wrap with
os.path.expanduser()before constructing thePathobject (line 245 ofvision_tools.py).Tests
Added two tests:
test_tilde_path_expanded_to_local_file— verifies~/image.pngresolves and analyzes successfullytest_tilde_path_nonexistent_file_gives_error— verifies graceful error for~/nonexistent.pngAll 45 vision tool tests pass.