fix: resolve OPENROUTER_API_KEY before OPENAI_API_KEY in all code paths#295
Merged
teknium1 merged 1 commit intoNousResearch:mainfrom Mar 3, 2026
Merged
Conversation
When both OPENROUTER_API_KEY and OPENAI_API_KEY are set (e.g. OPENAI_API_KEY in .bashrc), the wrong key was sent to OpenRouter causing auth failures. Fixed key resolution order in cli.py and runtime_provider.py. Fixes NousResearch#289
Contributor
4 tasks
teknium1
added a commit
that referenced
this pull request
Mar 7, 2026
…iority Authored by manuelschipper. Adds GLM-4.7 and GLM-5 context lengths (202752) to model_metadata.py. The key priority fix (prefer OPENAI_API_KEY for non-OpenRouter endpoints) was already applied in PR #295; merged the Z.ai mention into the comment.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OPENROUTER_API_KEYandOPENAI_API_KEYare set (e.g.OPENAI_API_KEYexported in.bashrc), the wrong key was sent to OpenRouter causing authentication failures.cli.pyandhermes_cli/runtime_provider.pyto checkOPENROUTER_API_KEYfirst.Fixes #289
Test plan
test_openrouter_key_takes_priority_over_openai_key-- both keys set, OpenRouter key winstest_openai_key_used_when_no_openrouter_key-- fallback still works when only OPENAI_API_KEY is set