fix(cron): close lock_fd on failed flock to prevent fd leak#296
Merged
teknium1 merged 1 commit intoNousResearch:mainfrom Mar 6, 2026
Merged
Conversation
Contributor
|
Merged in fec8a0d 🎉 Clean catch — in a long-running gateway ticking every minute, this would leak one fd per concurrent tick attempt. Thanks @alireza78a! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tick()openslock_fdbefore thetryblock, so iffcntl.flock()raisesBlockingIOError, the except clause returns without closing it. In a long-running gateway process where concurrent tick attempts are normal, this leaks a file descriptor on every skipped tick.Fix: initialize
lock_fd = Nonebefore the try block and close it in the except clause if it was opened.