fix(cli): refresh TUI before background task output to prevent status bar overlap#3048
Merged
fix(cli): refresh TUI before background task output to prevent status bar overlap#3048
Conversation
… bar overlap When a background task (/bg command) prints its output while the main agent is processing with the thinking spinner visible, the status bar could render on the same row as the spinner, causing visual overlap. This fix adds an explicit app.invalidate() call with a brief pause before printing background task output, ensuring the TUI layout is in a consistent state before the output is written. Changes: - Add TUI refresh before success output in _handle_background_command - Add TUI refresh before error output in the exception handler - Add tests for the refresh behavior Closes #2718
InB4DevOps
pushed a commit
to InB4DevOps/hermes-agent
that referenced
this pull request
Mar 25, 2026
… bar overlap (NousResearch#3048) When a background task (/bg command) prints its output while the main agent is processing with the thinking spinner visible, the status bar could render on the same row as the spinner, causing visual overlap. This fix adds an explicit app.invalidate() call with a brief pause before printing background task output, ensuring the TUI layout is in a consistent state before the output is written. Changes: - Add TUI refresh before success output in _handle_background_command - Add TUI refresh before error output in the exception handler - Add tests for the refresh behavior Closes NousResearch#2718 Co-authored-by: Bartok9 <bartokmagic@proton.me>
outsourc-e
pushed a commit
to outsourc-e/hermes-agent
that referenced
this pull request
Mar 26, 2026
… bar overlap (NousResearch#3048) When a background task (/bg command) prints its output while the main agent is processing with the thinking spinner visible, the status bar could render on the same row as the spinner, causing visual overlap. This fix adds an explicit app.invalidate() call with a brief pause before printing background task output, ensuring the TUI layout is in a consistent state before the output is written. Changes: - Add TUI refresh before success output in _handle_background_command - Add TUI refresh before error output in the exception handler - Add tests for the refresh behavior Closes NousResearch#2718 Co-authored-by: Bartok9 <bartokmagic@proton.me>
StreamOfRon
pushed a commit
to StreamOfRon/hermes-agent
that referenced
this pull request
Mar 29, 2026
… bar overlap (NousResearch#3048) When a background task (/bg command) prints its output while the main agent is processing with the thinking spinner visible, the status bar could render on the same row as the spinner, causing visual overlap. This fix adds an explicit app.invalidate() call with a brief pause before printing background task output, ensuring the TUI layout is in a consistent state before the output is written. Changes: - Add TUI refresh before success output in _handle_background_command - Add TUI refresh before error output in the exception handler - Add tests for the refresh behavior Closes NousResearch#2718 Co-authored-by: Bartok9 <bartokmagic@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a background task (
/bgcommand) prints its output while the main agent is processing with the thinking spinner visible, the status bar could render on the same row as the spinner, causing visual overlap.Adds
app.invalidate()+ 50ms pause before printing background task output (both success and error paths), giving prompt_toolkit a chance to complete pending TUI refreshes before output is written.Cherry-picked from PR #2727 by @Bartok9. Closes #2718.