fix(gateway/slack): send tool call progress messages to correct Slack thread#3063
Merged
fix(gateway/slack): send tool call progress messages to correct Slack thread#3063
Conversation
outsourc-e
pushed a commit
to outsourc-e/hermes-agent
that referenced
this pull request
Mar 26, 2026
…earch#3063) Co-authored-by: Jneeee <jneeee@outlook.com>
StreamOfRon
pushed a commit
to StreamOfRon/hermes-agent
that referenced
this pull request
Mar 29, 2026
…earch#3063) Co-authored-by: Jneeee <jneeee@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvage of PR #2956 by @jneeee — cherry-picked onto current main with authorship preserved.
Slack DM progress messages (tool call updates like
⚙️ read_file: ...) were going to the DM root instead of the reply thread. The final response correctly threaded under the user's message viareply_to, but progress messages had no thread anchor becausesource.thread_idisNonefor top-level DMs.Fix
Pass
event.message_idthrough to_run_agent()and usesource.thread_id or event_message_idas the thread anchor. Applied consistently to all three metadata sites: progress messages, status callbacks, and stream consumer.Tests
64 Slack tests pass (including 2 new ones for DM top-level and channel @mention thread behavior).
Closes #2956