fix(setup): use explicit key mapping for returning-user menu dispatch#3083
Merged
fix(setup): use explicit key mapping for returning-user menu dispatch#3083
Conversation
… instead of positional index
|
outsourc-e
pushed a commit
to outsourc-e/hermes-agent
that referenced
this pull request
Mar 26, 2026
… instead of positional index (NousResearch#3083) Co-authored-by: ygd58 <buraysandro9@gmail.com>
StreamOfRon
pushed a commit
to StreamOfRon/hermes-agent
that referenced
this pull request
Mar 29, 2026
… instead of positional index (NousResearch#3083) Co-authored-by: ygd58 <buraysandro9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes off-by-one in
hermes setupreturning-user menu.SETUP_SECTIONSincludes TTS but the menu skips it, so positional indexing dispatched the wrong section for choices 4-7 (e.g. picking Terminal launched TTS).Replaces
SETUP_SECTIONS[choice - 3]with explicit key list + lookup by key. Resilient to future additions.Cherry-picked from PR #2610 by @ygd58. Fixes #2609.