fix(reasoning): skip duplicate callback for <think>-extracted reasoning during streaming#3116
Merged
fix(reasoning): skip duplicate callback for <think>-extracted reasoning during streaming#3116
Conversation
…ng during streaming Local models (Ollama, LM Studio) embed reasoning in <think> tags in delta.content. During streaming, _stream_delta() already displays these blocks. Then _build_assistant_message() extracts them again and fires reasoning_callback, causing duplicate display. Track whether reasoning came from structured fields (reasoning_content) vs <think> tag extraction. Only fire the callback for <think>-extracted reasoning when stream_delta_callback is NOT active. Structured reasoning always fires regardless. Salvaged from PR #2076 by dusterbloom (Fix A only — Fix B was already covered by PR #3013's _current_reasoning_callback centralization). Closes #2069.
5 tasks
outsourc-e
pushed a commit
to outsourc-e/hermes-agent
that referenced
this pull request
Mar 26, 2026
…ng during streaming (NousResearch#3116) Local models (Ollama, LM Studio) embed reasoning in <think> tags in delta.content. During streaming, _stream_delta() already displays these blocks. Then _build_assistant_message() extracts them again and fires reasoning_callback, causing duplicate display. Track whether reasoning came from structured fields (reasoning_content) vs <think> tag extraction. Only fire the callback for <think>-extracted reasoning when stream_delta_callback is NOT active. Structured reasoning always fires regardless. Salvaged from PR NousResearch#2076 by dusterbloom (Fix A only — Fix B was already covered by PR NousResearch#3013's _current_reasoning_callback centralization). Closes NousResearch#2069.
StreamOfRon
pushed a commit
to StreamOfRon/hermes-agent
that referenced
this pull request
Mar 29, 2026
…ng during streaming (NousResearch#3116) Local models (Ollama, LM Studio) embed reasoning in <think> tags in delta.content. During streaming, _stream_delta() already displays these blocks. Then _build_assistant_message() extracts them again and fires reasoning_callback, causing duplicate display. Track whether reasoning came from structured fields (reasoning_content) vs <think> tag extraction. Only fire the callback for <think>-extracted reasoning when stream_delta_callback is NOT active. Structured reasoning always fires regardless. Salvaged from PR NousResearch#2076 by dusterbloom (Fix A only — Fix B was already covered by PR NousResearch#3013's _current_reasoning_callback centralization). Closes NousResearch#2069.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local models (Ollama, LM Studio) embed reasoning in
<think>tags indelta.content. During streaming,_stream_delta()already displays these blocks. Then_build_assistant_message()extracts them again and firesreasoning_callback, causing duplicate reasoning display.Track whether reasoning came from structured fields (
reasoning_content) vs<think>tag extraction. Only fire the callback for<think>-extracted reasoning whenstream_delta_callbackis NOT active. Structured reasoning always fires regardless.Salvaged from PR #2076 by @dusterbloom (Fix A only — Fix B was already covered by PR #3013's
_current_reasoning_callback()centralization). Closes #2069.