fix(session): preserve reasoning fields in rewrite_transcript#3311
Merged
fix(session): preserve reasoning fields in rewrite_transcript#3311
Conversation
rewrite_transcript (used by /retry, /undo, /compress) was calling append_message without reasoning, reasoning_details, or codex_reasoning_items — permanently dropping them from SQLite.
StreamOfRon
pushed a commit
to StreamOfRon/hermes-agent
that referenced
this pull request
Mar 29, 2026
…search#3311) rewrite_transcript (used by /retry, /undo, /compress) was calling append_message without reasoning, reasoning_details, or codex_reasoning_items — permanently dropping them from SQLite. Co-authored-by: alireza78a <alireza78.crypto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvaged from PR #3199 by @alireza78a — cherry-picked onto current main with original authorship preserved.
Root cause
rewrite_transcript()(called by/retry,/undo,/compress) clears all session messages from SQLite and re-inserts them — but dropsreasoning,reasoning_details, andcodex_reasoning_items. Sinceload_transcriptreads from SQLite first, the reasoning data is permanently lost for all future loads.Fix
Pass all three reasoning fields through to
append_message()inrewrite_transcript, gated onrole == "assistant"(only assistant messages carry reasoning).Validation
python -m pytest tests/gateway/test_session.py -n0 -q→ 54 passedCloses #3199
Co-authored-by: alireza78a alireza78.crypto@gmail.com