fix(signal): track SSE keepalive comments as connection activity#3316
Merged
fix(signal): track SSE keepalive comments as connection activity#3316
Conversation
signal-cli sends SSE comment lines (':') as keepalives every ~15s. The
SSE listener only counted 'data:' lines as activity, so the health
monitor reported false idle warnings every 2 minutes during quiet
periods. Recognize ':' lines as valid activity per the SSE spec.
Salvaged from PR #2938 by ticketclosed-wontfix.
StreamOfRon
pushed a commit
to StreamOfRon/hermes-agent
that referenced
this pull request
Mar 29, 2026
…sResearch#3316) signal-cli sends SSE comment lines (':') as keepalives every ~15s. The SSE listener only counted 'data:' lines as activity, so the health monitor reported false idle warnings every 2 minutes during quiet periods. Recognize ':' lines as valid activity per the SSE spec. Salvaged from PR NousResearch#2938 by ticketclosed-wontfix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
signal-cli sends SSE comment lines (
:) as keepalives every ~15s. The SSE listener only counteddata:lines as activity, so the health monitor reported falseSignal: SSE idle for 120swarnings every 2 minutes during quiet periods.Recognize
:lines as valid connection activity per the SSE spec, updating_last_sse_activityto suppress false idle warnings. Genuine connection drops are still detected (no keepalives = no activity updates).Salvaged from #2938 by @ticketclosed-wontfix.
Tests: 33 Signal gateway tests passed.