fix: cap context pressure percentage at 100% in display#3480
Merged
Conversation
The forward-looking token estimate can overshoot the compaction threshold (e.g. a large tool result pushes it from 70% to 109% in one step). The progress bar was already capped via min(), but pct_int was not — causing the user to see '109% to compaction' which is confusing. Cap pct_int at 100 in both CLI and gateway display functions. Reported by @JoshExile82.
|
Replace the rough chars/3 estimation with actual prompt_tokens + completion_tokens from the API response. The estimation was needed to predict whether tool results would push context past the threshold, but the default 50% threshold leaves ample headroom — if tool results push past it, the next API call reports real usage and triggers compression then. This removes all estimation from the compression and context pressure paths, making both 100% data-driven from provider-reported token counts. Also removes the dead _msg_count_before_tools variable.
|
binhnt92
added a commit
to binhnt92/hermes-agent
that referenced
this pull request
Mar 28, 2026
PR NousResearch#3480 capped context pressure at 100% in agent/display.py but missed the same unclamped pattern in 4 other files. When token counts overshoot the context length before compression fires, users see >100% in /stats, gateway status messages, and memory tool output. Apply min(100, ...) at all 5 remaining unclamped percentage sites.
3 tasks
teknium1
pushed a commit
that referenced
this pull request
Mar 28, 2026
Follow-up to PR #3480 which capped display.py but missed 5 other sites. Applies min(100, ...) to all remaining unclamped percentage calculations: - agent/context_compressor.py: get_status() usage_percent - cli.py: /stats command context percentage - gateway/run.py: gateway /stats handler - tools/memory_tool.py: _success_response() and _render_block() Includes 15 tests covering over-limit clamping, normal percentages, zero-denominator safety, and source-line verification.
teknium1
added a commit
that referenced
this pull request
Mar 28, 2026
…ol (#3599) Salvage of PR #3533 (binhnt92). Follow-up to #3480 — applies min(100, ...) to 5 remaining unclamped percentage display sites in context_compressor, cli /stats, gateway /stats, and memory tool. Defensive clamps now that the root cause (estimation heuristic) was already removed in #3480. Co-Authored-By: binhnt92 <binhnt92@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The context pressure display functions (
format_context_pressureandformat_context_pressure_gateway) didn't cap the percentage text, so users could see "109% to compaction" when the forward-looking token estimate overshoots the threshold in a single step (e.g. a large tool result).The progress bar was already capped via
min(), butpct_intwas not.Fix
Cap
pct_intat 100 in both CLI and gateway display functions.Tests
test_over_100_percent_cappedto verify text is capped (not just bar)Reported by @JoshExile82.