fix: auto-repair jobs.json with invalid control characters (salvage #3517)#3537
Merged
fix: auto-repair jobs.json with invalid control characters (salvage #3517)#3537
Conversation
load_jobs() uses strict json.load() which rejects bare control characters (e.g. literal newlines) in JSON string values. When a cron job prompt contains such characters, the parser throws JSONDecodeError and the function silently returns an empty list — causing ALL scheduled jobs to stop firing with no error logged. Fix: on JSONDecodeError, retry with json.loads(strict=False). If jobs are recovered, auto-rewrite the file with proper escaping via save_jobs() and log a warning. Only fall back to empty list if the JSON is truly unrecoverable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvage of #3517 by @zicochaos.
load_jobs()uses strictjson.load()which rejects bare control characters (literal newlines, tabs, etc.) inside JSON string values. When a cron job prompt contains such characters — which happens when LLM output with newlines gets saved — the parser throwsJSONDecodeErrorand the catch-all returns[]. All cron jobs silently stop firing with no error logged.Fix
On
JSONDecodeError, retry withjson.loads(strict=False)which accepts bare control characters. If jobs are recovered, auto-rewritejobs.jsonviasave_jobs()(which properly escapes everything viajson.dump) and log a warning. Only fall back to empty list if the JSON is truly unrecoverable.