Conversation
…n others but not the bot When DISCORD_IGNORE_NO_MENTION=true (default), if a message mentions other users but not the bot, the bot stays silent. Prevents the bot from interrupting conversations between humans in shared channels. Scoped to server channels only — DMs are excluded because the user is always talking to the bot there (mentions are just references).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of PR #3310 (luojiesi).
When
DISCORD_IGNORE_NO_MENTION=true(default), if a Discord message mentions other users but not the bot, the bot stays silent. Prevents the bot from interrupting conversations between humans in shared channels.Fix over original PR
Scoped to server channels only — DMs are excluded. In the original PR, a DM like "tell @alice about the project" would be silently dropped because
message.mentionsincludes Alice but not the bot. In DMs the user is always talking to the bot, so mentions are just references.How it works
The check runs in
on_messageafter bot filtering, before_handle_message():DISCORD_IGNORE_NO_MENTIONenv var (default:true)_handle_message()as normalComplements the existing
DISCORD_REQUIRE_MENTIONgating (which requires the bot to be @mentioned to respond). This new check handles the inverse case: someone explicitly @mentioning someone else.Tests
1621 gateway tests pass, 0 failures.
Closes #3310