fix(skills): stop marking persisted env vars missing on remote backends#3650
Merged
fix(skills): stop marking persisted env vars missing on remote backends#3650
Conversation
Removes the remote-backend short-circuit that marked ALL required env vars as missing regardless of whether they were persisted in .env. Skills now correctly show setup_needed=false when vars are available, regardless of backend (docker, ssh, modal, daytona, singularity). Also removes the unused backend parameter from _remaining_required_environment_names() since the remote-backend early return was the only consumer. Fixes #3433.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of PR #3452 (kentimsit).
Removes the remote-backend short-circuit in
skill_view()and_remaining_required_environment_names()that marked ALL required env vars as missing on Docker/SSH/Modal/Daytona/Singularity backends — even when the vars were already persisted in~/.hermes/.env.Skills now correctly show
setup_needed=falsewhen vars are available, regardless of backend.81 skill tests pass.
Note: This fixes the readiness check only. The actual forwarding of env vars into remote containers is a separate mechanism (
docker_forward_envconfig) that doesn't yet auto-populate from the skill passthrough registry — tracked as a future enhancement.Fixes #3433. Closes #3452.
Co-Authored-By: kentimsit kentimsit@users.noreply.github.com