fix(gateway): replace print() with logger calls in BasePlatformAdapter#3669
Merged
fix(gateway): replace print() with logger calls in BasePlatformAdapter#3669
Conversation
Converts 6 print() calls to proper logger calls in base.py: - photo follow-up queuing → logger.debug - interrupt trigger → logger.debug - media send failure → logger.warning - media send exception → logger.warning - queued message processing → logger.debug - message handler exception → logger.error(exc_info=True) Also removes redundant traceback.print_exc() since exc_info=True already captures the full traceback in the log.
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of PR #3616 (memosr).
Converts 6
print()calls ingateway/platforms/base.pyto proper logger calls. These fire on every incoming message across all gateway platforms — they should go through the logging system, not stdout.Also removes the now-redundant
import traceback; traceback.print_exc()sincelogger.error(..., exc_info=True)already captures the full traceback.1633 gateway tests pass.
Closes #3616
Co-Authored-By: memosr memosr@users.noreply.github.com