fix(gateway): use atomic writes for config.yaml to prevent data loss#3800
Merged
fix(gateway): use atomic writes for config.yaml to prevent data loss#3800
Conversation
Replace all 5 plain open(config_path, 'w') calls in gateway command handlers with atomic_yaml_write() from utils.py. This uses the established tempfile + fsync + os.replace pattern to ensure config.yaml is never left half-written if the process is killed mid-write. Affected handlers: /personality (clear + set), /sethome, /reasoning (_save_config_key helper), /verbose (tool_progress cycling). Also fixes missing encoding='utf-8' on the /personality clear write. Salvaged from PR #1211 by albatrosjj.
agent-bob-the-builder
pushed a commit
to agent-bob-the-builder/hermes-agent-ferris-fork
that referenced
this pull request
Mar 29, 2026
…ousResearch#3800) Replace all 5 plain open(config_path, 'w') calls in gateway command handlers with atomic_yaml_write() from utils.py. This uses the established tempfile + fsync + os.replace pattern to ensure config.yaml is never left half-written if the process is killed mid-write. Affected handlers: /personality (clear + set), /sethome, /reasoning (_save_config_key helper), /verbose (tool_progress cycling). Also fixes missing encoding='utf-8' on the /personality clear write. Salvaged from PR NousResearch#1211 by albatrosjj.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace all 5 plain
open(config_path, 'w')calls in gateway command handlers withatomic_yaml_write()fromutils.py. This uses the established tempfile + fsync + os.replace pattern to ensureconfig.yamlis never left half-written if the process is killed mid-write.Affected handlers:
/personality clear(also fixes missingencoding='utf-8')/personality set/sethome/reasoning(_save_config_keyhelper)/verbose(tool_progress cycling)Uses the existing shared
atomic_yaml_write()fromutils.pyrather than creating a new method — consistent with howsave_config()inhermes_cli/config.pyalready works.Salvaged from PR #1211 by @albatrosjj (also addresses the same issue as closed PR #3278 by @memosr).
Test plan
py_compileverification passes