fix(setup): auto-install matrix-nio during hermes setup#3802
Merged
Conversation
Adds a Ctrl+Z key binding to suspend the hermes CLI to background using standard Unix job control. Uses prompt_toolkit's run_in_terminal() to properly save/restore terminal state, then sends SIGTSTP to the process group. Prints a branded message with resume instructions. Shows a not-supported notice on Windows. Co-authored-by: CharlieKerfoot <CharlieKerfoot@users.noreply.github.com>
teknium1
force-pushed
the
hermes/hermes-9c6b6d00
branch
from
73ffba9 to
dbaa226
Compare
teknium1
changed the title
3 tasks
teknium1
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvaged from PR #1978 by @Gutslabs and PR #1979 by @cutepawss — applied onto current main with authorship preserved.
Setup previously only printed a manual install hint for
matrix-nio, causing the gateway to crash with "matrix-nio not installed" after configuring Matrix. Now auto-installs the package during setup.Changes:
hermes_cli/setup.py— Replaces the manual hint with auto-install logic using the same uv-first/pip-fallback pattern as Daytona and Modal backends. Installsmatrix-nio[e2e]when E2EE is enabled, plainmatrix-niootherwise. (from fix(setup): auto-install matrix-nio during hermes setup #1978)pyproject.toml— Addshermes-agent[matrix]to the[all]extra sopip install hermes-agent[all]includes it. (from fix(setup): auto-install matrix-nio during hermes setup #1978 and fix(install): include Matrix support in the default full install #1979)tests/test_project_metadata.py— Regression test ensuringhermes-agent[matrix]stays in the[all]group. (from fix(install): include Matrix support in the default full install #1979)Closes #1978, closes #1979