fix: omit tools param when empty instead of sending None#3820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
self.toolsis empty, the chat completions kwargs were sendingtools=None, which the OpenAI SDK serializes as"tools": nullin JSON. Some providers (Fireworks AI) reject this.PR #3736 proposed changing to
tools=[], but that trades one breakage for another — Anthropic and other strict providers reject empty arrays.The correct fix: don't include the
toolskey at all. The SDK treats a missing parameter asNOT_GIVENand omits it from the request entirely. Works with all providers.Inspired by #3736 (@kelsia14 identified the issue).