fix: update session_log_file during context compression#3835
Merged
Conversation
When compression creates a child session with a new session_id, session_log_file was still pointing to the old session's JSON file. This caused _save_session_log() to write new data to the wrong file. Closes #3731.
itsXactlY
pushed a commit
to itsXactlY/hermes-agent
that referenced
this pull request
Mar 30, 2026
…#3835) When compression creates a child session with a new session_id, session_log_file was still pointing to the old session's JSON file. This caused _save_session_log() to write new data to the wrong file. Closes NousResearch#3731. Co-authored-by: kelsia14 <kelsia14@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When context compression creates a child session with a new
session_id,session_log_filewas still pointing to the old session's JSON file. This caused_save_session_log()to write new data to the wrong file.Bug verified: After compression changes
self.session_id,self.session_log_fileretained the old path — confirmed by instantiating AIAgent, simulating the session_id change, and checking the file path.Fix: +2 lines following the existing pattern from
__init__(line 883).Salvaged from PR #3731 by @kelsia14 with authorship preserved.