fix(paths): respect HERMES_HOME for protected .env write-deny path#3840
Merged
fix(paths): respect HERMES_HOME for protected .env write-deny path#3840
Conversation
This was referenced Mar 30, 2026
itsXactlY
pushed a commit
to itsXactlY/hermes-agent
that referenced
this pull request
Mar 30, 2026
…ousResearch#3840) The write-deny list in file_operations.py hardcoded ~/.hermes/.env, which misses the actual .env in custom HERMES_HOME or profile setups. Use get_hermes_home() for profile-safe path resolution. Salvaged from PR NousResearch#3232 by @erhnysr. Co-authored-by: Erhnysr <erhnysr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The write-deny list in
file_operations.pyhardcoded~/.hermes/.env, which misses the actual.envin custom HERMES_HOME or profile setups. Usesget_hermes_home()for profile-safe path resolution.Salvaged from PR #3232 by @erhnysr with authorship preserved.
Note: PR #3205 (same author,
file_tools.py) was already fixed on main via commit e97c0cb.