fix(cli): handle closed stdout ValueError in safe print paths#3843
Merged
fix(cli): handle closed stdout ValueError in safe print paths#3843
Conversation
When stdout is closed (piped to a dead process, broken terminal),
Python raises ValueError('I/O operation on closed file'), not OSError.
_safe_print and the API error printer only caught OSError, letting the
ValueError propagate and crash the agent.
Salvaged from PR #3760 by @apexscaleai. Fixes #3534.
itsXactlY
pushed a commit
to itsXactlY/hermes-agent
that referenced
this pull request
Mar 30, 2026
…search#3843) When stdout is closed (piped to a dead process, broken terminal), Python raises ValueError('I/O operation on closed file'), not OSError. _safe_print and the API error printer only caught OSError, letting the ValueError propagate and crash the agent. Salvaged from PR NousResearch#3760 by @apexscaleai. Fixes NousResearch#3534. Co-authored-by: apexscaleai <apexscaleai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When stdout is closed (piped to a dead process, broken terminal), Python raises
ValueError('I/O operation on closed file'), notOSError._safe_printand the API error printer only caughtOSError, letting theValueErrorpropagate and crash the agent.Bug verified: Created an AIAgent with a print function that raises
ValueError— confirmed it crashes through_safe_printon current main, handled gracefully after the fix.Fixes #3534. Salvaged from PR #3760 by @apexscaleai with authorship preserved.