fix(cron): resolve human-friendly delivery labels via channel directory#3860
Merged
fix(cron): resolve human-friendly delivery labels via channel directory#3860
Conversation
Cron jobs configured with deliver labels from send_message(action='list') like 'whatsapp:Alice (dm)' passed the label as a literal chat_id. WhatsApp bridge failed with jidDecode error since 'Alice (dm)' isn't a valid JID. Now _resolve_delivery_target() strips display suffixes like ' (dm)' and resolves human-friendly names via the channel directory before using them. Raw IDs pass through unchanged when the directory has no match. Fixes #1945.
itsXactlY
pushed a commit
to itsXactlY/hermes-agent
that referenced
this pull request
Mar 30, 2026
…ry (NousResearch#3860) Cron jobs configured with deliver labels from send_message(action='list') like 'whatsapp:Alice (dm)' passed the label as a literal chat_id. WhatsApp bridge failed with jidDecode error since 'Alice (dm)' isn't a valid JID. Now _resolve_delivery_target() strips display suffixes like ' (dm)' and resolves human-friendly names via the channel directory before using them. Raw IDs pass through unchanged when the directory has no match. Fixes NousResearch#1945.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvage of the core fix from PR #1950 by @ifrederico (which was 549 commits behind and touched 20 files). Fixes #1945 reported by @dan-and.
The bug
Cron jobs set
deliver: "whatsapp:Alice (dm)"using the human-friendly labels fromsend_message(action="list")._resolve_delivery_target()passed"Alice (dm)"as a literalchat_idto the WhatsApp bridge, which failed with:The fix
_resolve_delivery_target()now:" (dm)"or" (group)"from the targetresolve_channel_name()from the channel directoryTests
3 new tests covering label resolution, plain name resolution, and raw ID passthrough. 39/39 scheduler tests pass.
Closes #1950. Fixes #1945. Credit to @ifrederico for the PR and @dan-and for the detailed bug report.