fix(cli): prevent status bar wrapping into duplicate rows#3883
Merged
teknium1 merged 1 commit intoNousResearch:mainfrom Mar 30, 2026
Merged
Conversation
- measure status bar display width using prompt_toolkit cell widths - trim rendered status text when fragments would overflow - add a final single-fragment fallback to prevent wrapping - update width assertions to validate display cells instead of len()
itsXactlY
pushed a commit
to itsXactlY/hermes-agent
that referenced
this pull request
Mar 30, 2026
…ch#3883) - measure status bar display width using prompt_toolkit cell widths - trim rendered status text when fragments would overflow - add a final single-fragment fallback to prevent wrapping - update width assertions to validate display cells instead of len()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The interactive CLI status bar can render as multiple visible rows over longer sessions even though it is intended to stay on a single line.
This shows up as repeated model/context rows accumulating at the bottom of the terminal when the rendered status content is just wide enough to wrap.
Root Cause
The status bar logic was treating Python string length as a safe proxy for rendered terminal width.
That is not always true for prompt_toolkit-rendered terminal output. A fragment set that looks short enough by
len()can still overflow the actual terminal cell width, wrap onto a second row, and leave behind duplicate-looking status lines over time.Fix
_get_status_bar_fragments()that collapses to a single trimmed fragment when neededlen()Testing
python -m pytest tests/test_cli_status_bar.py -q