fix(cli): support exporting the default root profile (#4366)#4370
Open
devorun wants to merge 1 commit intoNousResearch:mainfrom
Open
fix(cli): support exporting the default root profile (#4366)#4370devorun wants to merge 1 commit intoNousResearch:mainfrom
devorun wants to merge 1 commit intoNousResearch:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4366
The Issue:
Running
hermes profile export defaultcrashes with aFileNotFoundError. Theshutil.make_archivefunction was attempting to locate a directory nameddefaultinside the parent directory of~/.hermes(which resolves to~/default), resulting in an empty archive and an error because the directory is actually named.hermes.The Fix:
Added special handling for the
defaultprofile. The command now creates a temporary directory, structures it astempdir/default, and usesshutil.copytreeto copy the root profile contents into it.It intentionally ignores the
profiles/directory,gateway.pid, and sockets to prevent recursive copying of other profiles and runtime states. The archive is then generated safely from this temporary structure, allowing seamless exports and imports of the default profile.Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs