fix: _is_openai_client_closed handles is_closed as method (openai SDK >=2.21.0)#4383
Open
ekkoitac wants to merge 1 commit intoNousResearch:mainfrom
Open
fix: _is_openai_client_closed handles is_closed as method (openai SDK >=2.21.0)#4383ekkoitac wants to merge 1 commit intoNousResearch:mainfrom
ekkoitac wants to merge 1 commit intoNousResearch:mainfrom
Conversation
… >=2.21.0) In openai SDK v2.21.0+, OpenAI.is_closed is a bound method, not a bool property. bool(<bound method>) is always True, causing every API call to unnecessarily create+close+recreate the OpenAI client, adding ~100-200ms connection overhead per call. Fix: check if is_closed is callable and call it if so, falling back to the httpx _client.is_closed check. Also guard against http_client being None. Closes NousResearch#4377
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
_is_openai_client_closedfalse positive — openai SDKis_closedis a method, not a propertyFixes #4377
Problem
In openai SDK v2.21.0+,
OpenAI.is_closedis a bound method, not a bool property. The old code:bool(<bound method>)is alwaysTrue, even when the client is open. This causes every API call to:This adds ~100-200ms of connection overhead per API call.
Fix
Check if
is_closedis callable and call it if so:Also guard against
http_clientbeingNone.