fix(status): surface degraded gateway health for Telegram runtime failures#4393
Open
ajmeese7 wants to merge 2 commits intoNousResearch:mainfrom
Open
fix(status): surface degraded gateway health for Telegram runtime failures#4393ajmeese7 wants to merge 2 commits intoNousResearch:mainfrom
ajmeese7 wants to merge 2 commits intoNousResearch:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix gateway status reporting so Hermes no longer appears healthy when the gateway process is alive but Telegram runtime health is degraded.
This addresses the case where Telegram polling breaks behind the scenes, the gateway service stays running, and
hermes status/hermes gateway statusmisleadingly suggest everything is fine.Problem
Previously, Hermes could end up in a bad-but-running state:
hermes statusstill looked effectively healthyThat made failures on a primary messaging platform hard to detect and forced manual investigation.
What changed
Runtime health tracking
reconnectingwhile reconnect attempts are in progressconnectedwhen polling recovery succeedsfatalbehavior for real unrecoverable failuresRuntime state hygiene
Status classification
reconnecting/fatalas meaningful runtime problemsdisconnectedentriesCLI output
hermes statushermes status/hermes gateway statusExample outcome
Before:
After:
runningdegradedTests
Targeted tests added/updated for:
Example targeted run:
All targeted tests passed locally.
Related work
This complements prior Telegram gateway reliability fixes, especially:
This PR focuses on a separate but related problem: making
hermes statusandhermes gateway statusaccurately reflect degraded runtime health when the gateway process is still alive.