fix(cli): only pad short responses to anchor prompt near bottom#4394
Open
g1y5x3 wants to merge 1 commit intoNousResearch:mainfrom
Open
fix(cli): only pad short responses to anchor prompt near bottom#4394g1y5x3 wants to merge 1 commit intoNousResearch:mainfrom
g1y5x3 wants to merge 1 commit intoNousResearch:mainfrom
Conversation
The unconditional padding from NousResearch#4359 injected terminal_height//2 blank lines after every response, creating excessive whitespace between conversation exchanges regardless of response length. Now only pads when the response is shorter than terminal_height//3 lines, and the padding amount is reduced by the response length. Long responses that already fill the screen get zero padding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The unconditional padding from #4359 injected
terminal_height // 2blank lines after every response, creating excessive whitespace between conversation exchanges — regardless of response length. Even a response with tool output and a full response box got ~20 blank lines appended.Fix
terminal_height // 3linesThis preserves the original intent (short responses don't leave the prompt stranded mid-screen) while eliminating the excessive whitespace for normal/long responses.