fix(cli): remove post-response blank padding in TUI#4397
Closed
helix4u wants to merge 1 commit intoNousResearch:mainfrom
Closed
fix(cli): remove post-response blank padding in TUI#4397helix4u wants to merge 1 commit intoNousResearch:mainfrom
helix4u wants to merge 1 commit intoNousResearch:mainfrom
Conversation
Author
Author
|
handed off for a different fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What does this PR do?
Removes the extra post-response newline padding in the CLI TUI.
The CLI was inserting a large block of blank lines after each response to push the prompt lower in the terminal. In practice, this created a giant empty gap after short replies and made the interface feel broken during normal chat use.
This change removes that spacer output so the prompt appears directly after the response again.
Related Issue
N/A
Type of Change
Changes Made
cli.pytests/test_cli_prompt_spacing.pyto verify CLI turn cleanup does not emit blank spacer outputHow to Test
hermesChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Before:
After:
Test Notes
Targeted tests for this change pass:
pytest tests/test_cli_prompt_spacing.py -qpytest tests/test_cli_background_tui_refresh.py -qI also ran the full suite with
pytest tests/ -v, but it is not fully green on the current branch/worktree. The failures I saw were outside this CLI spacing change, including existing failures in:tests/gateway/test_api_server.pytests/test_api_key_providers.pytests/test_cli_init.pytests/agent/test_auxiliary_client.pytests/hermes_cli/test_models.pytests/tools/test_delegate.pytests/tools/test_tirith_security.pytests/tools/test_file_read_guards.py