fix(cli): initialize ctx_len before compact banner path#4399
Closed
helix4u wants to merge 1 commit intoNousResearch:mainfrom
Closed
fix(cli): initialize ctx_len before compact banner path#4399helix4u wants to merge 1 commit intoNousResearch:mainfrom
helix4u wants to merge 1 commit intoNousResearch:mainfrom
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a CLI startup crash in the compact banner path.
When Hermes starts in compact mode,
show_banner()could referencectx_lenbefore it was initialized. This caused anUnboundLocalErrorduring startup instead of showing the banner.This change initializes
ctx_lenbefore the compact/non-compact branch so both paths are safe.Related Issue
N/A
Type of Change
Changes Made
ctx_lenbefore the compact banner branch incli.pytests/test_cli_context_warning.pycovering compact mode with unknown context lengthHow to Test
hermesin a narrow terminal or with compact mode enabledUnboundLocalErrorChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/ATest Notes
Targeted tests for this change pass:
pytest tests/test_cli_context_warning.py -qpytest tests/hermes_cli/test_banner.py -q