fix: reset all retry counters at start of run_conversation()#607
Merged
teknium1 merged 1 commit intoNousResearch:mainfrom Mar 10, 2026
Merged
Conversation
_incomplete_scratchpad_retries and _codex_incomplete_retries were not reset at the start of run_conversation(). In CLI mode, where the same AIAgent instance is reused across conversations, stale counters from a previous conversation could carry over, causing premature retry exhaustion and partial responses.
Contributor
|
Merged — thanks @0xbyt4! Good eye spotting the missing resets. You're on a streak today 🔥 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_incomplete_scratchpad_retriesand_codex_incomplete_retriesare not reset at the start ofrun_conversation(). In CLI mode, the sameAIAgentinstance is reused across conversations, so stale counters carry over.Impact: After a few conversations with incomplete responses, the agent hits max retries immediately and returns partial results instead of retrying properly.
Fix: Add both counters to the existing reset block at the top of
run_conversation()(line 2884), alongside the other retry counters that are already reset there.Two-line fix — gateway is unaffected since it creates a fresh
AIAgentper message.