fix(security): prevent shell injection in sudo password piping#65
Merged
teknium1 merged 1 commit intoNousResearch:mainfrom Feb 27, 2026
Merged
Conversation
The sudo password was embedded in shell commands via single-quote
interpolation: echo '{password}' | sudo -S
If the password contained shell metacharacters (single quotes,
$(), backticks), they would be interpreted by the shell, enabling
arbitrary command execution.
Fix: use shlex.quote() which properly escapes all shell-special
characters, ensuring the password is always treated as a literal
string argument to echo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The sudo password in
_transform_sudo_command()was embedded in a shell command using single-quote interpolation:If the password contained shell metacharacters (single quotes,
$(), backticks), they would escape the quoting and be interpreted by the shell — enabling arbitrary command execution.Example — a password like
test'; rm -rf / #produces:Fix
Use
shlex.quote()which properly handles all shell-special characters:The same attack payload now produces:
Scope
Single file, 3-line change in
tools/terminal_tool.py. No behavior change for normal passwords —shlex.quote()is a no-op for simple alphanumeric strings.